-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios 10314-include custom fonts in mistica catalog app #376
Ios 10314-include custom fonts in mistica catalog app #376
Conversation
return "VivoType-Regular" | ||
} | ||
} | ||
case .o2, .movistar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.o2New
is missing
return "VivoType-Regular" | ||
} | ||
} | ||
case .o2, .movistar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.o2New
is missing
return "OnAir-Regular" | ||
} | ||
} | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to avoid using default
. Then if we add a new brand in the future, it will be forced to put that new brand in some case ;)
return "OnAir-Regular" | ||
} | ||
} | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to avoid using default
. Then if we add a new brand in the future, it will be forced to put that new brand in some case ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include TelefΓ³nica Sans to use it in TelefΓ³nica and TU skin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! π
β¦and added telefonica and tu font
β¦and added telefonica and tu font
done! |
return FontMapping( | ||
lightFont: "OnAir-Light", | ||
mediumFont: "OnAir", | ||
boldFont: "OnAir-Bold", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this OnAir-Bold
font missing in MisticaCatalog/Resources/
and in the Info.plist UIAppFonts
property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use DemiBold instead of Bold font weight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the documentation from Mistica's readme for the implementation of the Telefonica font.
https://github.com/Telefonica/mistica-ios/tree/main/Sources/MisticaCommon/Fonts
However, the brand documentation indicates, as you mentioned, using DemiBold, but it also indicates using Medium. In which cases should I choose the different font types?
https://brandfactory.telefonica.com/document/483#/nuestra-identidad-visual/tipografia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β¦onts-in-Mistica-Catalog-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! π€© Thanks!!
π This PR is included in version 31.0.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/IOS-10314
π₯ What's the goal?
Include custom fonts (Vivo & OnAir) in Mistica Catalog app.
π§ How do we do it?
Adding the fonts to the Mystica Catalog app and setting the FontStyle to match the selected brand's font.
π§ͺ How can I verify this?
The font changes to the selected brand: Vivo New, O2, or Movistar.
π AppCenter build
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public
Mistica Alpha - iOS 30.4.0 (1)